- 
                Notifications
    
You must be signed in to change notification settings  - Fork 10.5k
 
[IMP] general/payment_acquirers: rename and swap some headings #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
40d903f    to
    5c602e0      
    Compare
  
    5c602e0    to
    76df27a      
    Compare
  
    76df27a    to
    5d727a8      
    Compare
  
    5d727a8    to
    ef408e7      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
ef408e7    to
    b0379d8      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Demesmaeker !
Thanks for the PR. We (the documentation training group) have a suggestion to improve your content.
Feel free to take it or leave it.
@AntoineVDV it seems that the r+ didn't work.
| From an accounting perspective, we can distinguish two types of payment acquirers: the payment | ||
| acquirers that are third-party services and require you to follow another accounting workflow, and | ||
| the payments that go directly on the bank account and follow the usual reconciliation workflow. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too sure to understand but are you distinguishing payments acquirers such as PayPal that have their own "bank accounts" and you need to generate PayPal payslips, and direct payments?
The first one implies a movement between multiple accounts, and the other sends the money directly to the business' bank account.
| From an accounting perspective, we can distinguish two types of payment acquirers: the payment | |
| acquirers that are third-party services and require you to follow another accounting workflow, and | |
| the payments that go directly on the bank account and follow the usual reconciliation workflow. | |
| From an accounting perspective, we can distinguish two types of payment acquirers: | |
| - **Direct payment methods:** the payments go directly on your accounts and follow the usual | |
| reconciliation workflow (e.g., wire transfers and cash). | |
| - **Third-party services:** the payments go to the provider until you transfer them to your bank | |
| account (e.g., PayPal and Adyen). | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's about it but it's really not clear as it is now. We should make another PR to clarify all of this soon. In the meanwhile, I'm merging this one because it only swaps content without modifying it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineVDV
I beg to differ. My suggestion isn't the same.
previously "another accounting workflow" seemed a bit blurry, whereas "the payments go to the provider until you transfer them to your bank account" informs a lot more, imo.
| 
           @robodoo r+  | 
    
No description provided.